Message-ID: <004a01c2629b$9d5288c0$fe00a8c0 at hama>
From: "SooHyoung Oh" <shoh at duonix.com>
To: <lablgtk at kaba.or.jp>
Cc: "Jacques Garrigue" <garrigue at kurims.kyoto-u.ac.jp>
Subject: Some gToolbox fix
Date: Mon, 23 Sep 2002 09:53:20 +0900
MIME-Version: 1.0
Content-Type: text/plain;
	charset="ks_c_5601-1987"
Content-Transfer-Encoding: 7bit

(1) I think I found some bugs in gToolbox.ml.
If we use width height for GTree.tree,
it makes some limitation for viewing large tree.
This is the diff.

*** old/gToolbox.ml Mon Sep 23 09:30:43 2002
--- new/gToolbox.ml Mon Sep 23 09:07:14 2002
***************
*** 187,193 ****
    (* The scroll window used for the tree of the versions *)
    let wscroll_tree = GBin.scrolled_window ~packing: main_box#add () in
    (* The tree containing the versions *)
!   let wtree = GTree.tree ~width ~height
        ~packing:wscroll_tree#add_with_viewport () in
    (* the text widget used to display information on the selected node. *)
    let wtext = GEdit.text ~editable: false ~packing: main_box#pack () in
--- 187,193 ----
    (* The scroll window used for the tree of the versions *)
    let wscroll_tree = GBin.scrolled_window ~packing: main_box#add () in
    (* The tree containing the versions *)
!   let wtree = GTree.tree
        ~packing:wscroll_tree#add_with_viewport () in
    (* the text widget used to display information on the selected node. *)
    let wtext = GEdit.text ~editable: false ~packing: main_box#pack () in


(2) There seems to be some inconsitency in names or some bugs.
In GToolbox.popup_menu two arguments (x and y) seem to be used for location
but in menu#popup the first is used for "button" and the second is for
"time".
Which one did you intend?

GToolbox.popup_menu is defined as the followings
   GToolbox.popup_menu;;
   - : entries:GToolbox.menu_entry list -> x:int -> y:int -> unit = <fun>
                                                             ^           ^

In GToolbox.ml, popup_menu is defined to call menu#popup
   let menu = GMenu.menu () in
   ...
   menu#popup x y

And menu#popup has the following type
  # menu#popup;;
  - : button:int -> time:int -> unit = <fun>
       ^^^^^^          ^^^^

---
SooHyoung Oh
tel: 02)583-8709, 042)861-8649
cell. phone: 011-453-4303
web: http://www.duonix.com