Date: Fri, 10 Jun 2005 21:25:42 +0900 (JST)
Message-Id: <20050610.212542.108303247.garrigue at math.nagoya-u.ac.jp>
To: zack at cs.unibo.it
Cc: lablgtk at math.nagoya-u.ac.jp
Subject: Re: lablgtk2 patch for binding GtkSourceView
From: Jacques Garrigue <garrigue at math.nagoya-u.ac.jp>
In-Reply-To: <20050610082723.GA32571 at cs.unibo.it>
References: <20050610082723.GA32571 at cs.unibo.it>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

From: Stefano Zacchiroli <zack at cs.unibo.it>

> I've an almost complete binding of GtkSourceView to OCaml.
> 
> To implement it I needed a few changes in lablgtk2:
> - GtkSourceView inherits from GtkTextView, but the latter was not
>   designed to be extended (e.g. no buffer_skel class); thus I added it
OK
> - same for GtkSourceBuffer and GtkTextBuffer
OK
> - I dropped obj from the Gtk.text_buffer type in order to be able to
>   extend the variant type for inheritance
Seems that 90% of your patch is just for that.
But there's no real need for it: you can perfectly define
your own  source_buffer = [`textbuffer|`sourcebuffer] obj, and it will
work fine.
 
> The patch (against the latest CVS snapshot) is attached. Could you
> please consider applying it to lablgtk2 CVS? Otherwise I wont be able to
> release "lablgtksourceview" ...

I shall, but can you first provide me a version without the
Gtk.text_buffer changes. This would be easier to read.

Jacques