Delivered-To: garrigue at math.nagoya-u.ac.jp
Delivered-To: lablgtk at yquem.inria.fr
Message-ID: <493E553A.5060202 at comlab.ox.ac.uk>
Date: Tue, 09 Dec 2008 11:23:38 +0000
From: Mike Spivey <mike at comlab.ox.ac.uk>
MIME-Version: 1.0
To: lablgtk at yquem.inria.fr
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Lablgtk] Broken program name in about box

The "name" attribute of the about box is broken: I suspect it is linked
to the widget name, not to the name that is displayed.  As a result, the
program name that is displayed is always the default one ("about" in the
example program), not the one that has been set ("Name").

Recent versions of GTK have renamed the attribute to "program_name" to
avoid this confusion.  I suggest the following patch, which does the
same thing for lablgtk.

-- Mike

--- lablgtk-2.10.1/examples/about.ml 2007-06-20 08:40:34.000000000 +0100
+++ lablgtk-2.10.1-local/examples/about.ml 2008-12-09 11:06:09.000000000
+0000
@@ -12,7 +12,7 @@
let show () =
let dialog =
GWindow.about_dialog
- ~name:"Name"
+ ~program_name:"Name"
~authors:["Me" ;
"Myself";
]
diff -u -r lablgtk-2.10.1/src/gWindow.mli
lablgtk-2.10.1-local/src/gWindow.mli
--- lablgtk-2.10.1/src/gWindow.mli 2007-08-08 19:05:11.000000000 +0100
+++ lablgtk-2.10.1-local/src/gWindow.mli 2008-12-09 11:03:38.000000000 +0000
@@ -282,7 +282,7 @@
method license : string
method logo : GdkPixbuf.pixbuf
method logo_icon_name : string
- method name : string
+ method program_name : string
method translator_credits : string
method version : string
method website : string
@@ -297,7 +297,7 @@
method set_license : string -> unit
method set_logo : GdkPixbuf.pixbuf -> unit
method set_logo_icon_name : string -> unit
- method set_name : string -> unit
+ method set_program_name : string -> unit
method set_translator_credits : string -> unit
method set_version : string -> unit
method set_website : string -> unit
@@ -330,7 +330,7 @@
?license:string ->
?logo:GdkPixbuf.pixbuf ->
?logo_icon_name:string ->
- ?name:string ->
+ ?program_name:string ->
?translator_credits:string ->
?version:string ->
?website:string ->
diff -u -r lablgtk-2.10.1/src/gtkBase.props
lablgtk-2.10.1-local/src/gtkBase.props
--- lablgtk-2.10.1/src/gtkBase.props 2007-09-25 03:56:09.000000000 +0100
+++ lablgtk-2.10.1-local/src/gtkBase.props 2008-12-09 10:59:38.000000000
+0000
@@ -229,7 +229,7 @@
"license" gchararray : Read / Write
"logo" GdkPixbuf : Read / Write
"logo-icon-name" gchararray : Read / Write
- "name" gchararray : Read / Write
+ "program_name" gchararray : Read / Write
"translator-credits" gchararray : Read / Write
"version" gchararray : Read / Write
"website" gchararray : Read / Write

_______________________________________________
Lablgtk mailing list
Lablgtk@yquem.inria.fr
http://yquem.inria.fr/cgi-bin/mailman/listinfo/lablgtk