Delivered-To: lablgtk at yquem.inria.fr DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:received:date:to:subject:message-id:mail-followup-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent:from; bh=MQbjH20b9E2/tA+mROrV68xp4oErT0s798KbxRYHE8Y=; b=FeKw3FgoYDrM7mWzq0X1IUaCWGj1XVgEPpCrKWdWzohZxSfYPDkyEDr3JrpqHTIEhPc0mkXb0mQQAmXYR7u6VUhNtt4OlEP6nf+Uzlstm00FENzz+HFYPzxbxV56ZTFkl1RkP1xWP4glR3S8BFwACemQ/8KvH11gQ7+NO/+/BV8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:to:subject:message-id:mail-followup-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent:from; b=lNNJY44RW9OFAdLTPQeC96MBKyGAROMFmrtfCp4kFblWjz0DKTORZAb+27KVav8JCbgogh8XH+BISC/6fhcz+crhlR9F/0mrb3/0iZa3LbBJ4mGQFulZpBfhFPL2/SLjX+ULRF/j9OL9XsSO8u+ei+Dpk0KkjV458DI3soZzwSA= Date: Sat, 27 Oct 2007 11:45:09 +0200 To: lablgtk at yquem.inria.fr Subject: Re: [Lablgtk] Result of get_entry (of entry_completion) - really 'a option ? Message-ID: <20071027094509.GA9745 at localhost> Mail-Followup-To: Julien Moutinho , lablgtk@yquem.inria.fr References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: From: Julien Moutinho Content-Type: text/plain; charset=utf-8 Content-Length: 988 On Fri, Oct 26, 2007 at 02:14:41AM +0200, Dawid Toton wrote: > get_entry should return (Some x), that is a block with tag=0 and > Field(0)=x, but actually returns (as far as I can resolve) a block with > Custom_tag. Is it a bug? Is it safe? Looks so. I've proposed a fix on the branch "moutinho": http://svn.gna.org/viewcvs/lablgtk?rev=1388&view=rev It changes the signature of [GtkEdit.EntryCompletion.get_entry] from [Gtk.entry obj option] to [Gtk.entry obj], which may break user programs using this low-level function, but which seems a more coherent signature to my mind. And it changes the high-level method [GEdit.entry_completion#get_entry] to catch the [Gpointer.Null] exception that [GtkEdit.EntryCompletion.get_entry] may raise, hence [#get_entry] still returns a [GObj.widget option]. Thanks for spotting this, Julien. _______________________________________________ Lablgtk mailing list Lablgtk@yquem.inria.fr http://yquem.inria.fr/cgi-bin/mailman/listinfo/lablgtk